Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configurable results limit #204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: configurable results limit #204

wants to merge 2 commits into from

Conversation

tmarcinkowski-logitech
Copy link
Contributor

Description

Added a new prop for configuring the number of search results per page. Also, I added class names for "show more results" link.

Changelog

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested manually in our codebase.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jarekwg
Copy link
Member

jarekwg commented Oct 17, 2022

Hey @tmarcinkowski-logitech,

Thanks for your contribution, and apologies for the lack of response. We're actually looking for some help with maintenance of this repo. Czy byłbyś zainteresowany?

Cheers,

@tmarcinkowski-logitech
Copy link
Contributor Author

Cześć @jarekwg

I'm flattered, thanks. At this stage, I'm pretty happy with the functionality that the library provides and don't intend to develop it further. Also, entering the project as a regular maintainer might be difficult to combine with my day-to-day activities.

Thanks for asking though. I'll let you know in case anything changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmarcinkowski-logitech @jarekwg